Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed         (meson test, passed)
Implements feature:       tested, failed            (tested, passed)
Spec compliant:           not tested                   (tested, passed with suggestion)
Documentation:            not tested

Hi,

I have verified following:
  - Bug exits in PG17. I also checked it in PG16 but it does not exits there.
  - After applying your patch, I can confirm that bug get fixed.
  - no regression found. I ran "meson test".
  - I would like to suggest you that #includes should be included at appropriate location keeping the #includes alphabetically sorted, what I observed in the PG code as a standard:
    Your patch:
    #include <versionhelpers.h>
    #include <tlhelp32.h>

    It should be like:
    #include <tlhelp32.h>
    #include <versionhelpers.h>

Regards...


Yasir Hussain
Bitnine Global Inc.