Re: add function for creating/attaching hash table in DSM registry

Поиск
Список
Период
Сортировка
От Sami Imseih
Тема Re: add function for creating/attaching hash table in DSM registry
Дата
Msg-id CAA5RZ0tzabjrJT=kDSKcC33iMYPo1DuaKuJYK5BDWXzFbBj_eA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: add function for creating/attaching hash table in DSM registry  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: add function for creating/attaching hash table in DSM registry
Список pgsql-hackers
I tested v6 and I think GetNamedDSA is a good addition. I did
not find any issues with the code. However, I am still convinced
that GetNamedDSMHash  should not append " Hash" to the tranche
name of the dshash [0]. I am ok  with " DSA" because the DSA tranche
is created implicitly by the API.

Also, with GetNamedDSA not appending any suffixes, it will be
strange to have some extensions that use both GetNamedDSA
and GetNamedDSMHash finding that one API appends a suffix
and the other does not. but, maybe that's only my view.

[0] https://www.postgresql.org/message-id/CAA5RZ0sRkH8PfbwFPpYiqQWmSYmbH%2BBd0Vro%2BYZFvwxzed_6eQ%40mail.gmail.com

--
Sami



В списке pgsql-hackers по дате отправления: