Re: Issue with logical replication slot during switchover
| От | Fabrice Chapuis |
|---|---|
| Тема | Re: Issue with logical replication slot during switchover |
| Дата | |
| Msg-id | CAA5-nLCG=7hRC-Pyo1qveXg6JKzrYMteTegOvfTjNU2KznTYFA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Issue with logical replication slot during switchover (shveta malik <shveta.malik@gmail.com>) |
| Список | pgsql-hackers |
Thanks. I have refactored the code for synchronize_one_slot() as there
was some code-repetition. Please take it if you find it okay.
was some code-repetition. Please take it if you find it okay.
Ok for the goto retry.
Also I felt that when we create a slot through slot-synchronization,
we should create it with allow_overwrite as false. And thus in the
attached patch, I have changed that part as well.
Also I felt that when we create a slot through slot-synchronization,
we should create it with allow_overwrite as false. And thus in the
attached patch, I have changed that part as well.
The problem if allow_overwrite is set to false on the new standby it does not reflect the "allow_overwrite" parameter value set on the the primary instance.
At the moment we can let the slot creation with allow_overwrite set to false.
It is a top up patch. Attached it as txt, please rename before
applying atop your changes. Attached the steps for your reference.
At the moment we can let the slot creation with allow_overwrite set to false.
It is a top up patch. Attached it as txt, please rename before
applying atop your changes. Attached the steps for your reference.
The patch work fine. I generate the v3.
Regards
Fabrice
On Tue, Sep 30, 2025 at 11:41 AM shveta malik <shveta.malik@gmail.com> wrote:
On Tue, Sep 30, 2025 at 12:17 PM Fabrice Chapuis
<fabrice636861@gmail.com> wrote:
>
> Hi,
>
> Here the generated v2 of the Patch.
>
Thanks. I have refactored the code for synchronize_one_slot() as there
was some code-repetition. Please take it if you find it okay.
Also I felt that when we create a slot through slot-synchronization,
we should create it with allow_overwrite as false. And thus in the
attached patch, I have changed that part as well.
It is a top up patch. Attached it as txt, please rename before
applying atop your changes. Attached the steps for your reference.
thanks
Shveta
Вложения
В списке pgsql-hackers по дате отправления: