Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

On Mon, Nov 18, 2013 at 6:28 PM, Haribabu kommi
<haribabu.kommi@huawei.com> wrote:
> On 17 November 2013 12:25 Amit Kapila wrote:
>> On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi
>> >> >> Find the rebased version attached with this mail.
>> >> >
>> >                         ereport(ERROR,
>> >
>> (errcode(ERRCODE_CONFIG_FILE_ERROR),
>> >                                          errmsg("configuration file
>> \"%s\" contains errors",
>> > -
>> ConfigFileName)));
>> > +
>> > + ErrorConfFile)));
>> >
>> > The ErrorConfFile prints "postgresql.auto.conf" only if there is any
>> > parsing problem with postgresql.auto.conf otherwise it always print
>> "postgresql.conf" because of any other error.
>>
>>    Changed to ensure ErrorConfFile contains proper config file name.
>>    Note: I have not asssigned file name incase of error in below loop,
>> as file name in gconf is NULL in most cases and moreover this loops
>> over
>>             guc_variables which doesn't contain values/parameters from
>> auto.conf. So I don't think it is required to assign ErrorConfFile in
>> this loop.
>>
>> ProcessConfigFile(GucContext context)
>> {
>> ..
>>    for (i = 0; i < num_guc_variables; i++)
>>    {
>>        struct config_generic *gconf = guc_variables[i];
>>
>> ..
>> }
>
> Code changes are fine.
> If two or three errors are present in the configuration file, it prints the last error
> Configuration parameter file only. Is it required to be mentioned in the documentation?

Do you mean to say parsing errors or some run-time error, could you
explain with example?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com