Re: pgsql: Add support for prepared transactions to built-in logical replic

On Sat, Jul 31, 2021 at 10:11 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 30, 2021 at 6:17 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > Hi Amit,
> >
> > On Wed, Jul 14, 2021 at 02:41:43AM +0000, Amit Kapila wrote:
> > > Add support for prepared transactions to built-in logical replication.
> >
> > 021_twophase.pl, that has been introdeuced in this commit, is proving
> > to be a bit unstable:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=idiacanthus&dt=2021-07-30%2009%3A56%3A04
> > #   Failed test 'transaction is prepared on subscriber'
> > #   at t/021_twophase.pl line 324.
> > #          got: '1'
> > #     expected: '2'
> > # Looks like you failed 1 test of 24.
> > [12:14:02] t/021_twophase.pl ..................
> >
>
> Thanks for the report. I have shared my initial analysis in the
> corresponding -hackers thread [1].
>

I have pushed the fix for this [1].

[1] - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=eaf5321c352478266cebe2aa50ea4c34a8fdd2c7

-- 
With Regards,
Amit Kapila.