Re: [COMMITTERS] pgsql: Remove secondary checkpoint

On Sat, Nov 11, 2017 at 10:58 PM, Andreas Seltenreich
<seltenreich@gmx.de> wrote:
> Hi,
>
> sqlsmith doesn't like commit 4b0d28de06:
>
> ,----
> | regression=> select * from pg_control_checkpoint();
> | server closed the connection unexpectedly
> | TRAP: FailedAssertion("!((atti->attalign) == 's')", File: "heaptuple.c", Line: 126)
> `----
>
> On a build with assertions disabled, the statement fails with an error
> instead:
>
> ,----
> | regression=> select * from pg_control_checkpoint();
> | ERROR:  function return row and query-specified return row do not match
> | DETAIL:  Returned row contains 19 attributes, but query expects 18.
> `----
>
> The attached patch fixes it for me.
>


Your patch looks correct to me.  I can reproduce the problem and
verified that patch fixes the problem.  It is better to track this in
CF if not already tracked.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com