Re: PQexec() hangs on OOM

On Sun, Oct 11, 2015 at 6:31 PM, Michael Paquier <michael.paquier@gmail.com>
wrote:
>
>
> Yeah, this behavior is caused by this piece of code:
> @@ -600,7 +601,9 @@ getRowDescriptions(PGconn *conn, int msgLength)
>  advance_and_error:
>         /* Discard unsaved result, if any */
>         if (result && result != conn->result)
>                 PQclear(result);
> An idea may be to check for conn->result->resultStatus !=
> PGRES_FATAL_ERROR to concatenate correctly the error messages using
> pqCatenateResultError. But just returning the first error encountered
> as you mention would be more natural. So I updated the patch this way.
>

Minor comment:
+getParamDescriptions(PGconn *conn, int msgLength)
{
..
+
+ /*
+ * Advance inStart to show that the copy related message has been
+ * processed.
+ */
+ conn->inStart = conn->inCursor;
+
..
}

Reference to 'copy' in above comment seems to be wrong.


Other than that both the patches looks good to me, I will mark this as
Ready for committer.  Please see if you can update the patch soonish,
if you find above comment valid.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com