Re: Added schema level support for publication.
От | Amit Kapila |
---|---|
Тема | Re: Added schema level support for publication. |
Дата | |
Msg-id | CAA4eK1L3kAy7yEMGuYiKNb3+cCteL2mCMvOnXHpxSJidKt8P8A@mail.gmail.com обсуждение исходный текст |
Ответ на | RE: Added schema level support for publication. ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>) |
Ответы |
RE: Added schema level support for publication.
|
Список | pgsql-hackers |
On Wed, Sep 22, 2021 at 8:02 AM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote: > > On Wednesday, September 22, 2021 2:02 AM vignesh C <vignesh21@gmail.com> wrote: > > Attached v30 patch has the fixes for the same. > > Thanks for updating the patches. > > I have one comment. > @@ -474,7 +707,75 @@ AlterPublication(ParseState *pstate, AlterPublicationStmt *stmt) > ... > + if (list_length(relations)) > + { > ... > + /* remove the existing schemas from the publication */ > + PublicationDropSchemas(pubform->oid, delschemas, false); > ... > + } > > After more thoughts on it, I still don't think drop all the schemas under " if > (list_length(relations))" is a good idea. I think 1) we'd better keep schema > and relation code separate. > How do you suggest changing it? -- With Regards, Amit Kapila.
В списке pgsql-hackers по дате отправления: