Re: pgsql: Make the order of the header file includes consistent in backend

On Tue, Nov 12, 2019 at 8:33 AM Amit Kapila <akapila@postgresql.org> wrote:
>
> Make the order of the header file includes consistent in backend modules.
>

I see two buildfarm failures at this commit, but none seems to related
to this change.

1. The failure of anole seems to have happened earlier as well.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2019-11-12%2005%3A43%3A59
 --today's failure
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2019-07-18%2021%3A57%3A59
-- previous failure

2.  The failure of fairywren seems somewhat random.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2019-11-12%2005%3A57%3A00

The log shows:

not ok 44 - pgbench simple update stdout /(?^:builtin: simple update)/

#   Failed test 'pgbench simple update stdout /(?^:builtin: simple update)/'
#   at t/001_pgbench_with_server.pl line 162.
#                   ''
#     doesn't match '(?^:builtin: simple update)'
not ok 45 - pgbench simple update stdout /(?^:clients: 5\b)/

#   Failed test 'pgbench simple update stdout /(?^:clients: 5\b)/'
#   at t/001_pgbench_with_server.pl line 162.
#                   ''
#     doesn't match '(?^:clients: 5\b)'

It is not clear to me how it can be related to this commit.  If
anybody thinks so, please let me know.  I will wait for another run
and see if this gets reproduced.


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com