Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
| От | Amit Kapila |
|---|---|
| Тема | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Дата | |
| Msg-id | CAA4eK1KwrsGEZhT=p9htp1wsBvF+ubLVA5r=D-x=zPbiVS4vGQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file (Fujii Masao <masao.fujii@gmail.com>) |
| Ответы |
Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces
using a tablespace_map file
|
| Список | pgsql-hackers |
On Thu, Sep 10, 2015 at 9:29 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Sep 10, 2015 at 12:49 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Wed, Sep 9, 2015 at 6:43 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> >>
> >> On Fri, Sep 4, 2015 at 4:48 PM, Amit Kapila <amit.kapila16@gmail.com>
> >> wrote:
> >>
> >
> > - errdetail("Could not rename \"%s\" to \"%s\": %m.",
> > + errdetail("\"%s\" could not be renamed to \"%s\": %m.",
> >
> > Is there any reason to change this message?
> > I think you have changed this message to make it somewhat similar with
> > the new message we are planning to use in this function, but I don't see
> > that as compelling reason to change this message.
>
> The following part in error message style guide made me feel that's better.
>
> On Thu, Sep 10, 2015 at 12:49 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Wed, Sep 9, 2015 at 6:43 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> >>
> >> On Fri, Sep 4, 2015 at 4:48 PM, Amit Kapila <amit.kapila16@gmail.com>
> >> wrote:
> >>
> >
> > - errdetail("Could not rename \"%s\" to \"%s\": %m.",
> > + errdetail("\"%s\" could not be renamed to \"%s\": %m.",
> >
> > Is there any reason to change this message?
> > I think you have changed this message to make it somewhat similar with
> > the new message we are planning to use in this function, but I don't see
> > that as compelling reason to change this message.
>
> The following part in error message style guide made me feel that's better.
> IOW, I didn't think that the previous message follows complete-sentence style.
>
> -------------------------
> Detail and hint messages: Use complete sentences, and end each with a period.
> -------------------------
>
>
> -------------------------
> Detail and hint messages: Use complete sentences, and end each with a period.
> -------------------------
>
I am not sure if this indicates that previous used message was wrong.
If we look for errdetail in code, then there are many other similar messages.
В списке pgsql-hackers по дате отправления: