Re: parallel.c is not marked as test covered
От | Amit Kapila |
---|---|
Тема | Re: parallel.c is not marked as test covered |
Дата | |
Msg-id | CAA4eK1KcvkfT=jJ4=3vcJR-zfexNm5H2Fv+NQigidJgELnKOGA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: parallel.c is not marked as test covered (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>) |
Список | pgsql-hackers |
On Wed, Aug 17, 2016 at 1:34 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 6/20/16 11:16 PM, Tom Lane wrote: >>> > I think this test would only fail if it runs out of workers, and that >>> > would only happen in an installcheck run against a server configured in >>> > a nonstandard way or that is doing something else -- which doesn't >>> > happen on the buildfarm. >> Um, if you're speaking of select_parallel, that already runs in parallel >> with two other regression tests, and there is no annotation in the >> parallel_schedule file suggesting that adding more scripts to that group >> would be bad. But yes, perhaps putting this test into its own standalone >> group would be enough of a fix. > > Maybe now would be a good time to address this by applying the attached > patch to master and seeing what happens? > +1. Your patch looks good to me. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: