Re: Move PinBuffer and UnpinBuffer to atomics
От | Amit Kapila |
---|---|
Тема | Re: Move PinBuffer and UnpinBuffer to atomics |
Дата | |
Msg-id | CAA4eK1KXio7Akm+=cLsa_GUT04bHQa3OxH1_hELrTA8V7kaG8A@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Move PinBuffer and UnpinBuffer to atomics (Alexander Korotkov <a.korotkov@postgrespro.ru>) |
Список | pgsql-hackers |
On Fri, Apr 15, 2016 at 1:59 AM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
These results indicates that the patch is a win. Are these results median of 3 runs or single run data. By the way can you share the output of lscpu command on this m/c.
On Thu, Apr 14, 2016 at 5:35 AM, Andres Freund <andres@anarazel.de> wrote:On 2016-04-14 07:59:07 +0530, Amit Kapila wrote:
> What you want to see by prewarming?
Prewarming appears to greatly reduce the per-run variance on that
machine, making it a lot easier to get meaningful results. Thus it'd
make it easier to compare pre/post padding numbers.
> Will it have safe effect, if the tests are run for 10 or 15 mins
> rather than 5 mins?
s/safe/same/? If so, no, I doesn't look that way. The order of buffers
appears to play a large role; and it won't change in a memory resident
workload over one run.I've tried to run read-only benchmark of pad_pgxact_v1.patch on 4x18 Intel machine. The results are following.clients no-pad pad1 12997 133812 26728 256454 52539 517388 103785 10233710 132606 12617420 255844 25214330 371359 35762940 450429 44305350 497705 48825060 564385 56487770 718860 72514980 934170 93121890 1152961 1146498100 1240055 1300369110 1207727 1375706120 1167681 1417032130 1120891 1448408140 1085904 1449027150 1022160 1437545160 976487 1441720170 978120 1435848180 953843 1414925snapshot_too_old patch was reverted in the both cases.On high number of clients padding gives very significant benefit.
These results indicates that the patch is a win. Are these results median of 3 runs or single run data. By the way can you share the output of lscpu command on this m/c.
В списке pgsql-hackers по дате отправления: