Re: a fast bloat measurement tool (was Re: Measuring relation free space)
| От | Amit Kapila |
|---|---|
| Тема | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
| Дата | |
| Msg-id | CAA4eK1KVLcFhiQ+HOVhk8gMwaHnLzQHOXW3T98WtXOkiQJ=bGA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: a fast bloat measurement tool (was Re: Measuring relation free space) (Abhijit Menon-Sen <ams@2ndQuadrant.com>) |
| Ответы |
Re: a fast bloat measurement tool (was Re: Measuring
relation free space)
|
| Список | pgsql-hackers |
On Wed, Apr 22, 2015 at 6:33 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
>
> At 2015-04-18 12:28:36 +0530, amit.kapila16@gmail.com wrote:
> >
> > I think you have missed to address the below point:
> >
> > >> 4) prefetch
>
> Updated patch attached, as well as the diff against the earlier version
> just to make it easier to see the exact change I made (which is to copy
> the skip logic from lazy_scan_heap, as you suggested).
>
Few minor issues:
>
> At 2015-04-18 12:28:36 +0530, amit.kapila16@gmail.com wrote:
> >
> > I think you have missed to address the below point:
> >
> > >> 4) prefetch
>
> Updated patch attached, as well as the diff against the earlier version
> just to make it easier to see the exact change I made (which is to copy
> the skip logic from lazy_scan_heap, as you suggested).
>
Few minor issues:
1.
warning on windows
\pgstatbloat.c(193): warning C4715: 'pgstatbloat' : not all control paths return a value
2.
Failed to install pgstattuple--1.3.sql
You have to name sql file as pgstattuple--1.3.sql rather
than pgstattuple--1.2.sql
Other than above 2 points, patch looks good to me.
В списке pgsql-hackers по дате отправления: