Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash
Дата
Msg-id CAA4eK1KMkoCsa2TiG---53gJts6FVRPCHEJ3bat-8PNZ8gPUgQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash  ("Drouvot, Bertrand" <bdrouvot@amazon.com>)
Список pgsql-hackers
On Thu, Aug 12, 2021 at 12:15 PM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>
> On 8/10/21 1:59 PM, Drouvot, Bertrand wrote:
> > Hi Amit,
> >
>
> The first version of the patch contained a change in
> ReorderBufferToastReplace() (to put the call to
> RelationIsValid(toast_rel) and display the error message when it is not
> valid before the call to ReorderBufferChangeMemoryUpdate()).
>
> That way we also avoid the failed assertion described in the first
> message of this thread (but would report the error message instead).
>
> Forgot to mention that I did not add this change in the new patch
> version
>

I think that is the right decision.

-- 
With Regards,
Amit Kapila.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Следующее
От: Itamar Gafni
Дата:
Сообщение: RE: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags