Re: Confusing comment for function ExecParallelEstimate
От | Amit Kapila |
---|---|
Тема | Re: Confusing comment for function ExecParallelEstimate |
Дата | |
Msg-id | CAA4eK1K+6c1W6AkP1WFu_sVVnv1rw2oGH6iDV-tOB65Fe4BRkA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Confusing comment for function ExecParallelEstimate (Amit Kapila <amit.kapila16@gmail.com>) |
Ответы |
Re: Confusing comment for function ExecParallelEstimate
|
Список | pgsql-hackers |
On Thu, Jun 6, 2019 at 8:12 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei <wufei.fnst@cn.fujitsu.com> wrote: > > > > Sorry, Last mail forget to CC the mailing list. > > > > Now the comment is confusing, Maybe someone should correct it. > > > > Sure, for the sake of clarity, when this code was initially introduced > in commit d1b7c1ff, the structure used was > SharedPlanStateInstrumentation, but later when it got changed to > Instrumentation structure in commit b287df70, we forgot to update the > comment. So, we should backpatch this till 9.6 where it got > introduced. I will commit this change by tomorrow or so. > Pushed. Note, I was not able to apply your patch using patch -p1 command. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: