Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows

On Mon, Jun 19, 2017 at 11:42 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> Hi,
>
> On Fri, Mar 24, 2017 at 10:16 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Fri, Mar 24, 2017 at 6:44 AM, Kuntal Ghosh
>> <kuntalghosh.2007@gmail.com> wrote:
>>>> ASAICU, if we use binary mode, output is stored bit by bit. In ASCII
>>>> mode, cmd pokes its nose and does CR / LF conversions on its own. So,
>>>> whenever we want compression on a plain-text dump file, we can set the
>>>> stdout mode to O_BINARY. Is it a wrong approach?
>>> With the help from Ashutosh Sharma, I tested this in Windows
>>> environment. Sadly, it still doesn't work. :( IMHO, we should document
>>> the issue somewhere.
>>
>> Why not?  I mean, if there's code there to force the output into
>> binary mode, does that not work for the -Fc case?  And if it does work
>> for the -Fc case, then why doesn't it also work for -Z9?
>>
>
> I have re-verified the patch with the help of my colleague 'Neha
> Sharma' on Windows server 2008 R2 machine and the fix looks to be
> working fine. With the help of attached patch,
>

Did you intended to attach the patch to this e-mail or are you
referring to Kuntal's patch up thread?  If later, then it is better to
mention the link of mail which has a patch that you have verified.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com