Re: postgresql.auto.conf read from wrong directory
От | Amit Kapila |
---|---|
Тема | Re: postgresql.auto.conf read from wrong directory |
Дата | |
Msg-id | CAA4eK1JTHfFCdu51-+YHkL_mjUC09wsjB5pSqcrgPce-i_SLzA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: postgresql.auto.conf read from wrong directory (Amit Kapila <amit.kapila16@gmail.com>) |
Список | pgsql-hackers |
On Tue, May 27, 2014 at 10:35 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Sun, May 11, 2014 at 11:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I think it's clearly *necessary* to forbid setting data_directory in
> > postgresql.auto.conf. The file is defined to be found in the data
> > directory, so any such setting is circular logic by definition;
> > no good can come of not rejecting it.
> >
> > We already have a GUC flag bit about disallowing certain variables
> > in the config file (though I don't remember if it's enforced or
> > just advisory). It seems to me that we'd better invent one for
> > disallowing in ALTER SYSTEM, as well.
>
> I introduced a new flag bit (GUC_DISALLOW_IN_AUTO_FILE) to
> disallow parameters by Alter System and disallowed data_directory to
> be set by Alter System.
> On Sun, May 11, 2014 at 11:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I think it's clearly *necessary* to forbid setting data_directory in
> > postgresql.auto.conf. The file is defined to be found in the data
> > directory, so any such setting is circular logic by definition;
> > no good can come of not rejecting it.
> >
> > We already have a GUC flag bit about disallowing certain variables
> > in the config file (though I don't remember if it's enforced or
> > just advisory). It seems to me that we'd better invent one for
> > disallowing in ALTER SYSTEM, as well.
>
> I introduced a new flag bit (GUC_DISALLOW_IN_AUTO_FILE) to
> disallow parameters by Alter System and disallowed data_directory to
> be set by Alter System.
I have added this patch in next CF to avoid getting it lost.
В списке pgsql-hackers по дате отправления: