Re: logical streaming of xacts via test_decoding is broken

On Wed, Nov 11, 2020 at 10:00 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > >
> >
> > You can probably add a comment as to why we are disallowing this case.
> > I thought of considering 'stream-changes' parameter here because it
> > won't make sense to give this parameter without it, however, it seems
> > that is not necessary but maybe adding a comment
> > here in that regard would be a good idea.
>
> Should we also consider the case that if the user just passed
> skip_empty_streams to true then we should automatically set
> skip_empty_xacts to true?
>

Is there any problem if we don't do this? Actually, adding
dependencies on parameters is confusing so I want to avoid that unless
it is really required.

> And we will allow the 'skip_empty_streams' parameter only if
> stream-changes' is true.
>

Can't we simply ignore 'skip_empty_streams' if 'stream-changes' is not given?

-- 
With Regards,
Amit Kapila.