Re: pg_background (and more parallelism infrastructure patches)
| От | Amit Kapila |
|---|---|
| Тема | Re: pg_background (and more parallelism infrastructure patches) |
| Дата | |
| Msg-id | CAA4eK1J2kw2Pb4uK=iwPVVVAF_cquDMoN-gLkVGnMqcoYwKv-w@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pg_background (and more parallelism infrastructure patches) (Robert Haas <robertmhaas@gmail.com>) |
| Ответы |
Re: pg_background (and more parallelism infrastructure patches)
|
| Список | pgsql-hackers |
On Wed, Nov 12, 2014 at 11:09 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Wed, Nov 12, 2014 at 11:36 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> > On Wed, Nov 12, 2014 at 11:19 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> >> The question is whether the library is actually loaded in that case?
> >> Because that normally only happens early during startup - which is why
> >> it's a PGC_BACKEND guc.
> >
> > It looks like that does not work.
> >
> > [rhaas pgsql]$ PGOPTIONS='-c local_preload_libraries=auto_explain' psql
> > psql (9.5devel)
> > Type "help" for help.
> >
> > rhaas=# select * from pg_background_result(pg_background_launch('show
> > auto_explain.log_min_duration')) as (x text);
> > ERROR: unrecognized configuration parameter "auto_explain.log_min_duration"
> > CONTEXT: background worker, pid 31316
> >
> > So, there's more to be done here. Rats.
>
> It turned out to be quite simple to fix both problems.
>
> Updated patches attached.
>
Few compilation errors in the patch:
>
> On Wed, Nov 12, 2014 at 11:36 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> > On Wed, Nov 12, 2014 at 11:19 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> >> The question is whether the library is actually loaded in that case?
> >> Because that normally only happens early during startup - which is why
> >> it's a PGC_BACKEND guc.
> >
> > It looks like that does not work.
> >
> > [rhaas pgsql]$ PGOPTIONS='-c local_preload_libraries=auto_explain' psql
> > psql (9.5devel)
> > Type "help" for help.
> >
> > rhaas=# select * from pg_background_result(pg_background_launch('show
> > auto_explain.log_min_duration')) as (x text);
> > ERROR: unrecognized configuration parameter "auto_explain.log_min_duration"
> > CONTEXT: background worker, pid 31316
> >
> > So, there's more to be done here. Rats.
>
> It turned out to be quite simple to fix both problems.
>
> Updated patches attached.
>
Few compilation errors in the patch:
1>contrib\postgres_fdw\postgres_fdw.c(2107): error C2198: 'set_config_option' : too few arguments for call
1>contrib\postgres_fdw\postgres_fdw.c(2111): error C2198: 'set_config_option' : too few arguments for call
1>contrib\postgres_fdw\postgres_fdw.c(2115): error C2198: 'set_config_option' : too few arguments for call
2>contrib\dblink\dblink.c(2983): error C2198: 'set_config_option' : too few arguments for call
В списке pgsql-hackers по дате отправления: