Re: Regardign RecentFlushPtr in WalSndWaitForWal()
От | Amit Kapila |
---|---|
Тема | Re: Regardign RecentFlushPtr in WalSndWaitForWal() |
Дата | |
Msg-id | CAA4eK1J+k_7Z1+D108zaTZKiSszAnjdAMhogs6a7cKEsGFsjjQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Regardign RecentFlushPtr in WalSndWaitForWal() (shveta malik <shveta.malik@gmail.com>) |
Ответы |
Re: Regardign RecentFlushPtr in WalSndWaitForWal()
|
Список | pgsql-hackers |
On Mon, Mar 11, 2024 at 4:17 PM shveta malik <shveta.malik@gmail.com> wrote: > > On Sat, Mar 2, 2024 at 4:44 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > Right, I think the quoted code has check "if (!RecoveryInProgress())". > > > > > > > But apart from that, your > > > observation seems accurate, yes. > > > > > > > I also find the observation correct and the code has been like that > > since commit 5a991ef8 [1]. So, let's wait to see if Robert or Andres > > remembers the reason, otherwise, we should probably nuke this code. > > Please find the patch attached for the same. > LGTM. I'll push this tomorrow unless I see any comments/objections to this change. -- With Regards, Amit Kapila.
В списке pgsql-hackers по дате отправления: