Re: Ordering of header file inclusion

On Sun, Nov 10, 2019 at 5:30 PM vignesh C <vignesh21@gmail.com> wrote:
>
[review_latest_patch]:

Do we want to consider the ordering of map file inclusions as well
(see the changes pointed out below)?  If so, what all we should
validate, is compilation of these modules sufficient?  Tom, anyone, do
you have any opinion on this?

1.
 utf8_and_cyrillic.c

 #include "fmgr.h"
 #include "mb/pg_wchar.h"
-#include "../../Unicode/utf8_to_koi8r.map"
 #include "../../Unicode/koi8r_to_utf8.map"
-#include "../../Unicode/utf8_to_koi8u.map"
 #include "../../Unicode/koi8u_to_utf8.map"
+#include "../../Unicode/utf8_to_koi8r.map"
+#include "../../Unicode/utf8_to_koi8u.map"

 PG_MODULE_MAGIC;

2.
utf8_and_iso8859.c
..
 #include "../../Unicode/iso8859_13_to_utf8.map"
 #include "../../Unicode/iso8859_14_to_utf8.map"
 #include "../../Unicode/iso8859_15_to_utf8.map"
+#include "../../Unicode/iso8859_16_to_utf8.map"
 #include "../../Unicode/iso8859_2_to_utf8.map"
 #include "../../Unicode/iso8859_3_to_utf8.map"
 #include "../../Unicode/iso8859_4_to_utf8.map"
@@ -39,7 +41,6 @@
 #include "../../Unicode/utf8_to_iso8859_7.map"
 #include "../../Unicode/utf8_to_iso8859_8.map"
 #include "../../Unicode/utf8_to_iso8859_9.map"
-#include "../../Unicode/iso8859_16_to_utf8.map"


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com