Re: Wrong assert in TransactionGroupUpdateXidStatus

On Mon, Dec 16, 2019 at 8:53 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sun, Dec 15, 2019 at 8:51 AM Robert Haas <robertmhaas@gmail.com> wrote:
> >
> > On Thu, Dec 12, 2019 at 9:23 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > Do you think we need such an Assert after having StaticAssert for
> > > (THRESHOLD_SUBTRANS_CLOG_OPT <= PGPROC_MAX_CACHED_SUBXIDS)  and then
> > > an if statement containing (nsubxids <= THRESHOLD_SUBTRANS_CLOG_OPT)
> > > just before this Assert?  Sure, we can keep this for extra safety, but
> > > I don't see the need for it.
> >
> > I don't have strong feelings about it.
> >
>
> Okay, in that case, I am planning to push this patch [1] tomorrow
> morning unless I see any other comments.  I am also planning to
> backpatch this through 10 where it got introduced,
>

This was introduced in 11, so pushed and backpatched through 11.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com