Re: Synchronizing slots from primary to standby

On Tue, Feb 6, 2024 at 12:08 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi, I took another high-level look at all the funtion names of the
> slotsync.c file.
>
>
> Below are some suggestions (some are unchanged); probably there are
> better ideas for names but my point is that the current names could be
> improved:
>
> CURRENT                                 SUGGESTION
...
> check_sync_slot_on_remote     check_local_synced_slot_exists_on_remote
>

I think none of this seems to state the purpose of the function. I
suggest changing it to local_sync_slot_required() and returning false
either if the local_slot doesn't exist in remote_slot_list or is
invalidated.

--
With Regards,
Amit Kapila.