Re: backup manifests

On Sat, Mar 21, 2020 at 5:56 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
>
> On my CentOS, the patch gives below compilation failure:
> pg_validatebackup.c: In function ‘parse_manifest_file’:
> pg_validatebackup.c:335:19: error: assignment left-hand side might be
> a candidate for a format attribute [-Werror=suggest-attribute=format]
>   context.error_cb = report_manifest_error;
>
> I have tested it on Windows and found there are multiple failures.
> The failures are as below:
>

I have started to investigate the failures.

>
> Failure Report
> ------------------------
> t/002_algorithm.pl ..... 1/19
> #   Failed test 'backup ok with algorithm "none"'
> #   at t/002_algorithm.pl line 33.
>

I checked the log and it was giving error:

/src/bin/pg_validatebackup/tmp_check/t_002_algorithm_master_data/backup/none
--manifest-checksum none --no-sync
\tmp_install\bin\pg_basebackup.EXE: illegal option -- manifest-checksum

It seems the option to be used should be --manifest-checksums.  The
attached patch fixes this problem for me.

> t/002_algorithm.pl ..... 4/19 #   Failed test 'validate backup with
> algorithm "none"'
> #   at t/002_algorithm.pl line 53.
>

The error message for the above failure is:
pg_validatebackup: fatal: could not parse backup manifest: both
pathname and encoded pathname

I don't know at this stage what could cause this?  Any pointers?

Attached are logs of failed runs (regression.tar.gz).

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com