Re: Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

On Thu, Mar 27, 2014 at 1:39 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Mon, Mar 24, 2014 at 9:02 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> MarkBufferDirty() always increment BufferUsage counter
>> (shared_blks_dirtied) for dirty blocks whenever it dirties any
>> block, whereas same is not true for MarkBufferDirtyHint().
>> Is there any particular reason for not incrementing
>> shared_blks_dirtied in MarkBufferDirtyHint()?
>
> Hmm, I think that's a bug, dating back to this commit:
>
> commit 2254367435fcc4a31cc3b6d8324e33c5c30f265a

Right.
Do you think the fix attached in my previous mail is appropriate?
http://www.postgresql.org/message-id/CAA4eK1KQQSpNmfxg8Cg3-JZD23Q4Ee3iCsuLZGekH=DnaGPjRA@mail.gmail.com


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com