Re: parallel vacuum comments
От | Amit Kapila |
---|---|
Тема | Re: parallel vacuum comments |
Дата | |
Msg-id | CAA4eK1+FoAvGy_td8bcSjoBC3e+SbArjespGyq=PVZ7oFworag@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: parallel vacuum comments (Masahiko Sawada <sawada.mshk@gmail.com>) |
Список | pgsql-hackers |
On Tue, Dec 21, 2021 at 10:05 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > On Tue, Dec 21, 2021 at 12:05 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > On Mon, Dec 20, 2021 at 6:29 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > BTW, if we go with that then we should set the correct phase > > for workers as well? > > If we have separate error context for the leader (vacuumlazy.c) and > workers (vacuumparallel.c), workers don't necessarily need to have the > phases such as VACUUM_ERRCB_PHASE_VACUUM_INDEX and > VACUUM_ERRCB_PHASE_INDEX_CLEANUP. They can use PVIndVacStatus in the > error callback function as the patch does. > Okay. One minor point, let's change comments atop vacuum.c considering the movement of new functions. -- With Regards, Amit Kapila.
В списке pgsql-hackers по дате отправления: