Re: "pgoutput" options missing on documentation
От | Amit Kapila |
---|---|
Тема | Re: "pgoutput" options missing on documentation |
Дата | |
Msg-id | CAA4eK1+9QTR2t47tfJ5PN=Af_7JmJRO9K6TAn_WDsAKYXB5XcA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: "pgoutput" options missing on documentation (Emre Hasegeli <emre@hasegeli.com>) |
Ответы |
Re: "pgoutput" options missing on documentation
|
Список | pgsql-hackers |
On Mon, Dec 18, 2023 at 1:08 PM Emre Hasegeli <emre@hasegeli.com> wrote: > > > I found the existing error code appropriate because for syntax > > specification, either we need to mandate this at the grammar level or > > at the API level. Also, I think we should give a message similar to an > > existing message: "publication_names parameter missing". For example, > > we can say, "proto_version parameter missing". BTW, I also don't like > > the other changes parse_output_parameters() done in 0001, if we want > > to improve all the similar messages there are other places in the code > > as well, so we can separately make the case for the same. > > Okay, I am changing these back. I think we should keep the word > "option". It is used on other error messages. > Fair enough. I think we should push your first patch only in HEAD as this is a minor improvement over the current behaviour. What do you think? -- With Regards, Amit Kapila.
В списке pgsql-hackers по дате отправления: