Re: Relation extension scalability
От | Amit Kapila |
---|---|
Тема | Re: Relation extension scalability |
Дата | |
Msg-id | CAA4eK1+0iXR+jG_wQ_zB=5sLqP9JabocQykMUtsmuxRpx-_6Ng@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Relation extension scalability (Amit Kapila <amit.kapila16@gmail.com>) |
Ответы |
Re: Relation extension scalability
|
Список | pgsql-hackers |
On Sat, Jan 23, 2016 at 12:19 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
! UnlockReleaseBuffer(buffer);
! RecordPageWithFreeSpace(relation, BufferGetBlockNumber(buffer), freespace);
On Tue, Jan 12, 2016 at 2:41 PM, Dilip Kumar <dilipbalaut@gmail.com> wrote:On Thu, Jan 7, 2016 at 4:53 PM, Andres Freund <andres@anarazel.de> wrote:On 2016-01-07 16:48:53 +0530, Amit Kapila wrote:
I think it's a worthwhile approach to pursue. But until it actually
fixes the problem of leaving around uninitialized pages I don't think
it's very meaningful to do performance comparisons.Attached patch solves this issue, I am allocating the buffer for each page and initializing the page, only after that adding to FSM.Few comments about patch:
I found one more problem with patch.
! RecordPageWithFreeSpace(relation, BufferGetBlockNumber(buffer), freespace);
You can't call BufferGetBlockNumber(buffer) after releasing
the pin on buffer which will be released by
UnlockReleaseBuffer(). Get the block number before unlocking
the buffer.
В списке pgsql-hackers по дате отправления: