Re: [PATCH] Fix crash when disabling auto commit

Поиск
Список
Период
Сортировка
От Sanket Mehta
Тема Re: [PATCH] Fix crash when disabling auto commit
Дата
Msg-id CA+yw=mMH0fTn13RAmCRQSBx4Evv1L5sd5_HTTy7hqCmvYk3WdA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Fix crash when disabling auto commit  (Sanket Mehta <sanket.mehta@enterprisedb.com>)
Ответы Re: [PATCH] Fix crash when disabling auto commit
Список pgadmin-hackers
Дерево обсуждения
Hi John,

I have tried to reproduce the scenario but not able to reproduce the crash in my system.
can you please provide your steps which causes crash on your machine?

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jun 12, 2015 at 11:50 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

I am looking into the same and few other issues in code and will send the patch soon.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jun 12, 2015 at 1:49 AM, John Obaterspok <john.obaterspok@gmail.com> wrote:
Fix crash when string has only alphas (like 'rollback')

diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp
index b5a2f56..110bbc7 100644
--- a/pgadmin/frm/frmQuery.cpp
+++ b/pgadmin/frm/frmQuery.cpp
@@ -2522,7 +2522,7 @@ bool frmQuery::isBeginNotRequired(wxString query)
  /*
  * Check word length (since "beginx" is not "begin").
  */
- while(wxIsalpha(query.GetChar(wordlen)))
+ while(wordlen < query.Length() && wxIsalpha(query.GetChar(wordlen)))
  wordlen++;
 
  /*


В списке pgadmin-hackers по дате отправления: