On Wed, Dec 7, 2022 at 12:12 PM Andres Freund <andres@anarazel.de> wrote:
> On 2022-12-07 00:58:06 +1300, Thomas Munro wrote:
> > One way to fix that for the epoll version is to EPOLL_CTL_DEL and
> > EPOLL_CTL_ADD, whenever transitioning to/from a zero event mask.
> > Tried like that in this version. Another approach would be to
> > (finally) write DeleteWaitEvent() to do the same thing at a higher
> > level... seems overkill for this.
>
> What about just recreating the WES during crash restart?
It seems a bit like cheating but yeah that's a super simple solution,
and removes one patch from the stack. Done like that in this version.
> > > This seems to hardcode the specific wait events we're waiting for based on
> > > latch.c infrastructure. Not really convinced that's a good idea.
> >
> > What are you objecting to? The assumption that the first socket is at
> > position 1? The use of GetNumRegisteredWaitEvents()?
>
> The latter.
Removed.