Re: refactoring - share str2*int64 functions

On Fri, May 24, 2019 at 3:23 AM Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> >> Although I agree it is not worth a lot of trouble, and even if I don't do
> >> Windows, I think it valuable that the behavior is the same on all platform.
> >> The attached match shares pg_str2*int64 functions between frontend and
> >> backend by moving them to "common/", which avoids some code duplication.
> >>
> >> This is more refactoring, and it fixes the behavior change on 32 bit
> >> architectures.
>
> V2 is a rebase.

Hi Fabien,

Here's some semi-automated feedback, noted while going through
failures on cfbot.cputube.org.  You have a stray editor file
src/backend/parser/parse_node.c.~1~.  Something is failing to compile
while doing the temp-install in make check-world, which probably
indicates that some test or contrib module is using the interface you
changed?

-- 
Thomas Munro
https://enterprisedb.com