Re: WIP checksums patch

On 1 October 2012 18:04, Jeff Davis <pgsql@j-davis.com> wrote:
> On Mon, 2012-10-01 at 12:35 -0400, Bruce Momjian wrote:
>> The heap/index files are copied unmodified from the old cluster, so
>> there are no checksums on the pages.
>
> That's fine though, the patch still reads the old format the same way,
> and the pages are treated as though they have no checksum.

> How is that a
> reason for defaulting the GUC to off?

It's not.

> Are we worried about users who turn the GUC
> on and then expect all of their old data pages to magically be
> protected?

Yes, but as you say, that is a separate consideration.

You are missing large parts of the previous thread, giving various
opinions on what the UI should look like for enabling checksums.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services