Re: Add shutdown_at_recovery_target option to recovery.conf

On 19 November 2014 16:41, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Wed, Nov 19, 2014 at 10:49 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Wed, Nov 19, 2014 at 8:13 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>> If we ask for PAUSE and we're not in HotStandby it just ignores it,
>>> which means it changes into PROMOTE. My feeling is that we should
>>> change that into a SHUTDOWN, not a PROMOTE.
>>
>> To me, that seems like a definite improvement.
>
> But changing the default will force us to set
> action_at_recovery_target to 'promote'
> when we want to just recover the database to the specified point.

If you explicitly request pause and then can't pause, ISTM the action
we actually perform shouldn't be the exact opposite of what was
requested.

So if the user explicitly requests pause and we aren't in HS then they
should get Shutdown, which is closest action.

If the user doesn't request anything at all then we can default to
Promote, just like we do now.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services