Re: [PATCH 08/14] Store the number of subtransactions in xl_running_xacts separately from toplevel xids

On 14 November 2012 22:17, Andres Freund <andres@2ndquadrant.com> wrote:

> To avoid complicating logic we store both, the toplevel and the subxids, in
> ->xip, first ->xcnt toplevel ones, and then ->subxcnt subxids.

That looks good, not much change. Will apply in next few days. Please
add me as committer and mark ready.

> Also skip logging any subxids if the snapshot is suboverflowed, they aren't
> useful in that case anyway.

> This allows to make some operations cheaper and it allows faster startup for
> the future logical decoding feature because that doesn't care about
> subtransactions/suboverflow'edness.

...but please don't add extra touches of Andres magic along the way.
Doing that will just slow down patch acceptance and its not important.
I suggest to keep note of things like that and come back to them
later.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services