Re: pgsql: Avoid tricky race condition recording XLOG_HINT
| От | Simon Riggs |
|---|---|
| Тема | Re: pgsql: Avoid tricky race condition recording XLOG_HINT |
| Дата | |
| Msg-id | CA+U5nMJ306zQOHY0wvtj-33erGAhGR3Yo2fyPH4EHTZMaszyrg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgsql: Avoid tricky race condition recording XLOG_HINT (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: pgsql: Avoid tricky race condition recording XLOG_HINT
|
| Список | pgsql-committers |
On 8 April 2013 15:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Simon Riggs <simon@2ndQuadrant.com> writes:> src/include/catalog/catversion.h | 2 +-
> Resulting code completely changes layout of XLOG_HINT WAL records, but
> this isn't even beta code, so this is a low impact change.
Just for the record, the right way to handle that kind of change is to
change XLOG_PAGE_MAGIC, not catversion. A database's catalog version
might not be available to code that is inspecting WAL files and would
like to know what format it should expect.
I was so happy Andres had remembered to bump the catversion like I often do, it didn't occur to me it was the wrong one. My bad, sorry.
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-committers по дате отправления: