Re: pgbench - allow backslash-continuations in custom scripts

<div dir="ltr">On Thu, Feb 18, 2016 at 6:54 AM, Kyotaro HORIGUCHI <span dir="ltr"><<a
href="mailto:horiguchi.kyotaro@lab.ntt.co.jp"target="_blank">horiguchi.kyotaro@lab.ntt.co.jp</a>></span> wrote:<br
/><divclass="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1pxsolid rgb(204,204,204);padding-left:1ex">It is the SQL part of old psqlscan.l but the difference
between<br/> them is a bit bothersome to see. I attached the diff between them<br /> as "psqlscanbody.l.diff" for
convenience.<br/></blockquote></div><br /></div><div class="gmail_extra">This is a huge diff, and I don't see that
you'veexplained the reason for all the changes.  For example:<br /><br />-/*<br />- * We use a stack of flex buffers to
handlesubstitution of psql variables.<br />- * Each stacked buffer contains the as-yet-unread text from one psql
variable.<br/>- * When we pop the stack all the way, we resume reading from the outer buffer<br />- * identified by
scanbufhandle.<br/>- */<br />-typedef struct StackElem<br />-{<br />-       YY_BUFFER_STATE buf;            /* flex
inputcontrol structure */<br />-       char       *bufstring;          /* data actually being scanned by flex *<br
/>/<br/>-       char       *origstring;         /* copy of original data, if needed */<br />-       char      
*varname;           /* name of variable providing data, or N<br />ULL */<br />-       struct StackElem *next;<br />-}
StackElem;<br/><br /></div><div class="gmail_extra">Perhaps we could separate this part of the code motion into its own
preliminarypatch?  I see this went to psqlscan_int.h, but there's no obvious reason for that particular name, and the
commentsdon't explain it; in fact, they say that's psqlscan.h.  psqlscan_slash.h has the same problem; perhaps moving
thingsthere could be another preliminary patch.<br /><br />-                                       yyless(0);<br
/>+                                      my_yyless(0);<br /><br clear="all" /></div><div class="gmail_extra">Why do we
needto do this?  Is "my_" really the best prefix?  Is this another change that could be its own patch?<br /><br
/></div><divclass="gmail_extra">-- <br /><div class="gmail_signature">Robert Haas<br />EnterpriseDB: <a
href="http://www.enterprisedb.com"target="_blank">http://www.enterprisedb.com</a><br />The Enterprise PostgreSQL
Company</div></div></div>