Re: [HACKERS] Parallel worker error

On Fri, Sep 8, 2017 at 1:17 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> You are right.  I have changed the ordering and passed OuterUserId via
> FixedParallelState.

This looks a little strange:

+    SetCurrentRoleId(fps->outer_user_id, fps->is_current_user_superuser);

The first argument says "outer" but the second says "current".  I'm
wondering if we can just make the second one is_superuser.

I'm also wondering if, rather than using GetConfigOptionByName, we
should just make the GUC underlying is_superuser non-static and use
the value directly.  If not, then I'm alternatively wondering whether
we should maybe use a less-generic name than varval.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers