Re: pgsql: Get rid of the dynamic shared memory state file.

On Tue, Apr 8, 2014 at 4:14 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2014-04-08 15:45:39 +0000, Robert Haas wrote:
>> Get rid of the dynamic shared memory state file.
>>
>> Instead of storing the ID of the dynamic shared memory control
>> segment in a file within the data directory, store it in the main
>> control segment.  This avoids a number of nasty corner cases,
>> most seriously that doing an online backup and then using it on
>> the same machine (e.g. to fire up a standby) would result in the
>> standby clobbering all of the master's dynamic shared memory
>> segments.
>>
>> Per complaints from Heikki Linnakangas, Fujii Masao, and Tom
>> Lane.
>
> Looks like it's not working for windows yet:
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2014-04-08%2016%3A31%3A18
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=baiji&dt=2014-04-08%2017%3A00%3A01
>
> There's also the to_reg* commit in the ones tested by those runs, but it
> sounds unlikely that those would trigger during initdb.

Crap.  I did test that it worked with EXEC_BACKEND, but I don't have a
Windows environment set up.  I can try to eyeball the code and see
what might be wrong with it, but...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company