Re: [PATCH] pg_regress and non-default unix socket path

On Tue, Apr 9, 2013 at 8:08 AM, Christoph Berg <cb@df7cb.de> wrote:
> Debian has been patching pg_regress for years because our default unix
> socket directory is /var/run/postgresql, but that is not writable by
> the build user at build time. This used to be a pretty ugly "make-
> patch-make check-unpatch-make install" patch dance, but now it is a
> pretty patch that makes pg_regress accept --host=/tmp.
>
> The patch is already part of the .deb files on apt.postgresql.org and
> passes all regression test suites there.
>
> Please consider it for 9.3. (And maybe backpatch it all the way...)

The hunk that changes the messages might need some thought so that it
doesn't cause a translation regression.  But in general I see no
reason not to do this before we release beta1.  It seems safe enough,
and changes that reduce the need for packagers to carry private
patches are, I think, generally a good thing.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company