Re: Template for commit messages
| От | Robert Haas |
|---|---|
| Тема | Re: Template for commit messages |
| Дата | |
| Msg-id | CA+TgmobhYwRiJ_740rEqiWZuWax4g7gxN5R2z3cCvAbq1pA3RQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Template for commit messages (Tomas Vondra <tomas.vondra@2ndquadrant.com>) |
| Ответы |
Re: Template for commit messages
|
| Список | pgsql-hackers |
On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote: > On 01/28/2016 01:57 PM, Robert Haas wrote: >> One of the things I like about the current free-form approach is that >> you can indicate nuances, like: >> >> Person X reviewed an earlier version of this patch that was a lot >> different than this one. >> Person X reviewed this patch but didn't totally endorse it. >> Person X wrote the documentation for the patch, but none of the code. >> Person X wrote the vast bulk of this patch, even though there are some >> other authors. >> >> Should I just abandon the idea of trying to capture those details, or >> does this format contemplate a way to include them? > > Why can't we do both? That is, have a free-form text with the nuances, and > then Reviewed-By listing the main reviewers? The first one is for humans, > the other one for automated tools. I'm not objecting to or endorsing any specific proposal, just asking what we want to do about this. I think the trick if we do it that way will be to avoid having it seem like too much duplication, but there may be a way to manage that. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: