Re: Comment in src/backend/commands/vacuumlazy.c

On Mon, Mar 24, 2014 at 12:28 AM, Amit Langote <amitlangote09@gmail.com> wrote:
> Hi,
>
> Note the following comment in src/backend/commands/vacuumlazy.c:lazy_scan_heap()
>
> 1088     /* If no indexes, make log report that lazy_vacuum_heap
> would've made */
> 1089     if (vacuumed_pages)
> 1090         ereport(elevel,
>
> Just wondering if it would read better as:
>
> 1088     /* Make the log report that lazy_vacuum_heap would've made
> had there been no indexes */
>
> Is that correct?

No.  Your rewrite means the opposite of what the comment means now.
vacuumed_pages will be non-zero only if the relation does NOT have
indexes.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company