Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

On Wed, Jun 10, 2015 at 3:34 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> Okay, I have updated the patch to destroy_tablespace_directories() code
> as well in the attached patch. I have tried to modify
> remove_tablespace_symlink(), so that it can be called from
> destroy_tablespace_directories(), but that is making it more complex,
> especially due to the reason that destroy_tablespace_directories()
> treats ENOENT as warning rather than ignoring it.

This pretty obviously doesn't follow style guidelines.  You've got it
started with a capital letter, and there are two spaces between "a"
and "directory".
                errmsg("Not a  directory or symbolic link: \"%s\"",

But it looks OK otherwise, so committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company