On Sat, Jun 5, 2021 at 11:03 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > This added a PQtraceSetFlags() function. We have a dozen PQset*() functions,
> > but this and PQresultSetInstanceData() are the only PQSomethingSet()
> > functions. Is it okay if I rename it to PQsetTraceFlags()? I think that
> > would be more idiomatic for libpq.
>
> Hmm, there is an obvious parallel between PQtrace() and
> PQtraceSetFlags() which is lost with your proposed rename. I'm not
> wedded to the name though, so I'm just -0.1 on the rename. If you feel
> strongly about it, I won't oppose it.
I'm +1 for the rename. I think it's a lot more idiomatic.
--
Robert Haas
EDB: http://www.enterprisedb.com