Re: event trigger test exception message

On Sun, Jan 4, 2015 at 8:09 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Andrew Dunstan wrote:
>> I don't wish to seem humorless, but I think this should probably be changed:
>>
>> root/HEAD/pgsql/src/test/regress/sql/event_trigger.sql:248:  RAISE EXCEPTION
>> 'I''m sorry Sir, No Rewrite Allowed.';
>>
>> Quite apart from any other reason, the "Sir" does seem a bit sexist - we
>> have no idea of the gender of the reader. Probably just 'sorry, no rewrite
>> allowed' would suffice.
>
> This seems pointless tinkering to me.  Should I start introducing female
> pronouns in test error messages, to measure how much this will annoy my
> male conterparts?  This is not a user visible message in any case.

I'm with Andrew.  Aside from any question of sexism, which I do not
discount, the capitalization is wrong.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company