Re: ENABLE/DISABLE CONSTRAINT NAME

On Tue, Sep 24, 2013 at 10:40 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On Tue, 2013-09-24 at 11:58 +0200, Bernd Helmle wrote:
>> Hmm not sure i understand this argument either: this patch doesn't
>> allow disabling a primary key. It only supports FKs and CHECK
>> constraints explicitly.
>
> Well, as soon as the patch for cataloging not-null constraints as check
> constraints is available, it will be possible to create views that
> depend functionally on check constraints.  Then you'll have the same
> problem there.
>
> It's also not clear why this patch only supports foreign keys and check
> constraints.  Maybe that's what was convenient to implement, but it's
> not a principled solution to the general issue that constraints can be
> involved in dependencies.

I agree with these concerns, as well as those raised by Tom Lane and
Fabien COELHO, and I think they indicate that we shouldn't accept this
patch.  So I'm marking this as Rejected.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company