Re: extend pgbench expressions with functions

On Mon, Mar 28, 2016 at 9:36 PM, Stephen Frost <sfrost@snowman.net> wrote:
> * Michael Paquier (michael.paquier@gmail.com) wrote:
>> On Tue, Mar 29, 2016 at 9:54 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> > On Sun, Mar 27, 2016 at 5:01 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>> >> v40 is yet another rebase.
>> >
>> > Thanks.  Committed after removing an unnecessary parameter from the
>> > coerceToXXX() functions.
>> >
>> > I guess the question here is whether we want the part-c patch, which
>> > removes the historical \setrandom syntax.  That's technically no
>> > longer needed since we now can use random() as a function directly
>> > inside \set commands, but we might want it anyway for backward
>> > compatibility.
>> >
>> > Anybody have an opinion on that?
>>
>> +1 for nuking it. That's not worth the trouble maintaining it.
>
> If we don't nuke it, it'll never die.
>
> See also: pg_shadow

Hearing no objections, BOOM.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company