Re: More legacy code: pg_ctl

On Mon, Nov 18, 2013 at 8:20 PM, Josh Berkus <josh@agliodbs.com> wrote:
> On 11/18/2013 05:09 PM, Josh Berkus wrote:
>> Folks,
>>
>> Speaking of legacy code with bad default behaviors: pg_ctl.  The current
>> utility is designed to fathfully reproduce the rather hackish shell
>> script we originally had for postgres startup.   This results in a
>> couple of unintuitive defaults which give sysadmins and config
>> management developers headaches:
>>
>> a) by default, it returns to the caller without waiting for postgres to
>> actually start/stop/restart.  In this mode, it also always returns
>> success regardless of result.
>>
>> b) by default, it remains attached to the caller's tty for stdout and
>> stderr, even after it has switched to the regular postgres log.
>
> Oh, and one more:
>
> c) that "stop" defaults to "smart" mode, instead of "fast" mode.

And that "smart" mode is called "smart" instead of "footgun".

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company