Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

On Sat, Jan 6, 2018 at 7:38 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> It's definitely concerning that the submitted patch introduced a new bug,
> but we have seldom taken the position that bugs in an initial submission
> are sufficient grounds for rejecting the entire concept.

Fair point.  I withdraw my categorical -1 vote and replace it with the
statement that the patch hasn't been sufficiently-carefully checked by
the patch author or other reviewers for bugs to consider committing it
-- nor has anyone taken the trouble to list with precision all of the
places where the behavior will change.  I think the latter is
absolutely indispensable, which is why I started to compile such a
list in my previous post.  The former needs to be done as well, of
course.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company