Re: Skipping PgStat_FunctionCallUsage for many expressions

On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund <andres@anarazel.de> wrote:
> while working on my faster expression evaluation stuff I noticed that a
> lot of expression types that call functions don't call the necessary
> functions to make track_functions work.
>
> ExecEvalFunc/ExecEvalOper (via ExecMakeFunctionResultNoSets) call
> pgstat_init_function_usage/pgstat_end_function_usage, but others like
> ExecEvalRowCompare, ExecEvalMinMax, ExecEvalNullIf, ExecEvalDistinct,
> ExecEvalScalarArrayOp (and indirectly ExecEvalArrayCoerceExpr) don't.
>
> Similarly InvokeFunctionExecuteHook isn't used very thoroughly.
>
> Are these worth fixing? I suspect yes. If so, do we want to backpatch?

If it doesn't torpedo performance, I assume we should fix and back-patch.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company