Re: Avoid mix char with bool type in comparisons

On Fri, Oct 7, 2022 at 11:40 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> FWIW, I did take a look at this code, and I don't see any bug.
> The entryRes[] array entries are indeed GinTernaryValue, but it's
> obvious by inspection that matchPartialInPendingList only returns
> true or false, therefore collectMatchesForHeapRow also only deals
> in true or false, never maybe.  I do not think changing
> matchPartialInPendingList to return ternary would be an improvement,
> because then it'd be less obvious that it doesn't deal in maybe.

I mean if the code isn't buggy, I'm glad, but I think there should
have been more substantial grounds for getting you to spend time
looking at it. It's not asking too much for people to produce a
non-zero amount of evidence that the thing they are worried about is
actually a problem.

-- 
Robert Haas
EDB: http://www.enterprisedb.com